[Bugfix] Triton pressureCurve #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eggrobin
approved these changes
Mar 31, 2018
eggrobin
requested changes
Mar 31, 2018
| key = 90000 5.86825E-05 -2.85739E-09 -2.85739E-09 | ||
| key = 103000 3.20278E-05 -1.42561E-09 -1.42561E-09 | ||
| key = 0 0.00165 0 -1.11539E-06 | ||
| key = 2000 0.00143845 -1.00036E-06 -1.00036E-06 |
There was a problem hiding this comment.
The derivatives (third and fourth columns) need to be divided by ten too.
eggrobin
approved these changes
Mar 31, 2018
There was a problem hiding this comment.
This looks good to me (thanks for aligning the columns by the way, it's a whole lot more readable this way).
@Bornholio, can you test that the pressure behaves nicely now as you go from 0 m to 110 km?
|
Yea...whoops! I forgot that i had to change all pressure-related values. Semi-offtopic but someone also reported that the Mars pressure curve may also be wrong/off. Will take a look at it. |
|
starting in 20 minutes, also i noticed there is a huge variation on scientifically reported values for triton. |
Bornholio
approved these changes
Mar 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Log: